Changeset 33

Timestamp:

12/14/07 13:58:02 (11 months ago)

Author:

simon

Message:

Changed table generation to use innerHTML and made the table HTML source available for collecting results from different browsers together.

Files:

• collected/trunk/html-test-cases/getting-tabindex.html (modified) (5 diffs)

collected/trunk/html-test-cases/getting-tabindex.html

@@ -7 +7 @@
 <title>Getting the tabindex value of an element with JavaScript</title>
 <script type="text/javascript">
-function Logger(id){
-        this._id = id;
+function Logger(){
+        this._rows = "";
 }
-Logger.prototype._makeTd = function(text){
-        var td = document.createElement("td");
-        td.appendChild(document.createTextNode(text));
-        return td;
+Logger.prototype.log = function(desc, mechanism, value){
+        value = (value === null) ? "null" : value;
+        this._rows += "<tr><td>" + desc + "<\/td><td>"
+                + mechanism + "<\/td><td>" + value + "<\/td><\/tr>\n";
 };
-Logger.prototype.log = function(desc, mechanism, value){
-        var table = document.getElementById(this._id);
-        var tbody = table.getElementsByTagName("tbody")[0];
-        var tr = document.createElement("tr");
-        tr.appendChild(this._makeTd(desc));
-        tr.appendChild(this._makeTd(mechanism));
-        if(value === null){
-                tr.appendChild(this._makeTd("null"));
-        }else{
-                tr.appendChild(this._makeTd(value));
-        }
-        tbody.appendChild(tr);
+Logger.prototype.getHTML = function(){
+        return "<table><thead>"
+                + "<tr><th>Element<\/th><th>Mechanism<\/th><th>Value<\/th><\/tr>"
+                + "<\/thead><tbody>\n"
+                + this._rows
+                + "<\/tbody><\/table>\n";
 };
 Logger.prototype.logGetAttribute = function(id, desc, attr, iFlags){
@@ -76 +70 @@
         return navigator.userAgent.indexOf("MSIE") != -1;
 }
+function showTableSource(){
+        document.getElementById("source").style.display = "block";
+}
 function removeTabindex(id){
         var elem = document.getElementById(id);
@@ -89 +86 @@
         removeTabindex("div-tabindex-removed");
         removeTabindex("input-tabindex-removed");
-        logger = new Logger("log");
+        logger = new Logger();
         logger.logTabindex("div-no-tabindex", "div with no tabindex");
         logger.logTabindex("div-tabindex-1", 'div with tabindex="1"');
@@ -96 +93 @@
         logger.logTabindex("input-tabindex-1", 'input with tabindex="1"');
         logger.logTabindex("input-tabindex-removed", "input with tabindex removed");
+        document.getElementById("log").innerHTML = logger.getHTML();
+        var sourceTextNode = document.createTextNode(logger.getHTML());
+        document.getElementById("source").appendChild(sourceTextNode);
 }
 </script>
@@ -104 +104 @@
 <div id="userAgent"></div>
 <h2>Results</h2>
-<table id="log">
-<thead>
-<tr><th>Element</th><th>Mechanism</th><th>Value</th></tr>
-</thead>
-<tbody></tbody>
-</table>
+<div id="log"></div>
+<hr>
+<div><button onclick="showTableSource()">Show table source</button></div>
+<pre id="source" style="display:none"></pre>
 <hr>
 <div id="div-no-tabindex"></div>
 <div id="div-tabindex-1" tabindex="1"></div>
 <div id="div-tabindex-removed" tabindex="1"></div>
+<div>
 <input id="input-no-tabindex">
 <input id="input-tabindex-1" tabindex="1">
 <input id="input-tabindex-removed" tabindex="1">
+</div>
 </body>